Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Cutadapt compression level problem #153

Merged
merged 5 commits into from
Feb 1, 2024
Merged

fix: Cutadapt compression level problem #153

merged 5 commits into from
Feb 1, 2024

Conversation

uniqueg
Copy link
Member

@uniqueg uniqueg commented Feb 1, 2024

Description

Upgrading Cutadapt resolves the issue (only tested for Conda execution).

Fixes #152

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Conventional Commits guidelines

Checklist:

  • My code changes follow the style of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • I have updated the project's documentation

@uniqueg
Copy link
Member Author

uniqueg commented Feb 1, 2024

I didn't change the HTSinfer workflow for which the tests are failing. I assume that is because HTSinfer was updated today and a few other times, recently, probably leading to different results. During heavy development, it was probably okay to always use the latest HTSinfer version - but I think for the publication now we should start pinning the HTSinfer so that we get predictable/reproducible behavior and outcomes (and also support the new HTSinfer Bioconda release).

@balajtimate
@mkatsanto

@balajtimate
Copy link
Contributor

The HTSinfer result JSON was changed in the latest build, so I updated to checksums of the workflow test results to reflect that.

The pipeline was failing with the newest release 0.10.0 of snakefmt (with version 24.1.1 of Black) apparently there was a new line missing from the Snakefile, so added that.

@uniqueg
Copy link
Member Author

uniqueg commented Feb 1, 2024

Thanks @balajtimate! I am now preparing a PR for #154 - where I will also include the upgrade for Cutadapt. I will leave this open for now, so that we can try out both (in case the other one gives problems).

@uniqueg uniqueg changed the title fix: Cutadapt compression level problem WIP: fix: Cutadapt compression level problem Feb 1, 2024
@uniqueg uniqueg changed the title WIP: fix: Cutadapt compression level problem fix: Cutadapt compression level problem Feb 1, 2024
@uniqueg uniqueg marked this pull request as draft February 1, 2024 13:12
@mkatsanto mkatsanto marked this pull request as ready for review February 1, 2024 15:55
@uniqueg uniqueg merged commit d6811e7 into dev Feb 1, 2024
11 checks passed
@uniqueg uniqueg deleted the cutadapt_issue branch February 1, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: Cutadapt compression level problem
3 participants