Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(htsinfer): interface log and cluster log dirs via config.yaml #146

Merged
merged 2 commits into from
Sep 6, 2023

Conversation

ninsch3000
Copy link
Collaborator

@ninsch3000 ninsch3000 commented Sep 6, 2023

Description

reading log and cluster log directory paths from config, instead of building them inside the Snakefile. Like this, compatibility with other parts of ZARP-cli is ensured.

Fixes #145

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Conventional Commits guidelines

Checklist:

  • My code changes follow the style of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • I have updated the project's documentation

@uniqueg
Copy link
Member

uniqueg commented Sep 6, 2023

Seems like the test is not run?

Also, weird that the rule graph test failed!?

@ninsch3000
Copy link
Collaborator Author

The test is not run on CI, no. I ran it locally and there it ran through.
Might want to create an issue for including an actual test in the ci

@uniqueg uniqueg merged commit 7acbac6 into dev Sep 6, 2023
11 of 13 checks passed
@uniqueg uniqueg deleted the patch_145 branch September 6, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(htsinfer): Interface log and cluster log directories via config.yaml
2 participants