Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix synchronous_mode/synchronous_mode_strict ignored when set to false #2709

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

drivebyer
Copy link
Contributor

In my use case, I import the package from https://github.com/zalando/postgres-operator/tree/master/pkg/apis/acid.zalan.do/v1 into my Golang project. In my project, I use Golang to populate the PostgreSQL resource, and then use client-go to create the resource. However, when updating the PostgreSQL resource, like setting spec.patroni.synchronousMode to false, it gets ignored after marshaling to a string because of the omitempty tag. In my opinion, these fields should not have the omitempty tag.

@drivebyer
Copy link
Contributor Author

PTAL @FxKu

@FxKu
Copy link
Member

FxKu commented Aug 9, 2024

hm - this is contrary to #1223. Always thought omitempty only omits the field when it's not specified, but not on false. But anyway, why is it important to list, when the mode is disabled? With a simple coalesce logic you should be able to check for nil and insert whatever you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants