Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use unique cluster alias as identifier rather than redundant eksID #817

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

linki
Copy link
Member

@linki linki commented Sep 17, 2024

Using eksID() generates redundant and unreadable EKS cluster names, as well as other resources that are based on it.

For example, a cluster with alias playground-2 will have an EKS resource named aws--123456789012--eu-central-1--kube-1 for which the ARN will become a long, unreadable and redundant:

arn:aws:eks:eu-central-1:123456789012:cluster/aws--123456789012--eu-central-1--kube-1

[Update] Since the merge of #818 the ARN will look like this:

arn:aws:eks:eu-central-1:123456789012:cluster/kube-1

This isn't too bad, but it's unclear which cluster "kube-1" is. One has to use the AWS account ID to figure that out. Subsequent clusters in the same account would likely use "kube-2", "kube-3" etc. which isn't really helpful.

With this change the cluster will show in the UI as playground-2 and will always be unique as long as we pick unique cluster aliases. The ARN will become more useful and correct:

arn:aws:eks:eu-central-1:123456789012:cluster/playground-2
  • Let's decommission any incompatible EKS cluster before merging this.

@linki linki added the minor Minor changes, e.g. low risk config updates, changes that do not introduce a new API call. label Sep 17, 2024
@linki linki changed the title use unique cluster alias as identifier rather than redundant eksID Use unique cluster alias as identifier rather than redundant eksID Sep 17, 2024
@demonCoder95
Copy link
Member

👍

@demonCoder95
Copy link
Member

LGTM, once we decommission playground-eks we can merge I guess.

@linki
Copy link
Member Author

linki commented Sep 18, 2024

It's a little to much change at the moment. I'll put it on hold.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge minor Minor changes, e.g. low risk config updates, changes that do not introduce a new API call.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants