Merge pull request backstage#3614 from backstage/freben/master-fix

cost-insights: fix react-hooks/exhaustive-deps error
zalando-incubator · Dec 8, 2020 · faa7be4 · faa7be4
2 parents 1e50e1f + 90458fe
commit faa7be4
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/.changeset/friendly-news-know.md b/.changeset/friendly-news-know.md
@@ -0,0 +1,5 @@
+---
+'@backstage/plugin-cost-insights': patch
+---
+
+fix react-hooks/exhaustive-deps error
diff --git a/plugins/cost-insights/src/components/ProductInsightsCard/ProductInsightsChart.tsx b/plugins/cost-insights/src/components/ProductInsightsCard/ProductInsightsChart.tsx
@@ -70,8 +70,10 @@ export const ProductInsightsChart = ({
  const layoutClasses = useLayoutStyles();
 
  // Only a single entities Record for the root product entity is supported
- const entityLabel = assertAlways(findAnyKey(entity.entities));
- const entities = entity.entities[entityLabel] ?? [];
+ const entities = useMemo(() => {
+ const entityLabel = assertAlways(findAnyKey(entity.entities));
+ return entity.entities[entityLabel] ?? [];
+ }, [entity]);
 
  const [activeLabel, setActive] = useState<Maybe<string>>();
  const [selectLabel, setSelected] = useState<Maybe<string>>();