Merge pull request #6 from jeroendoggen/main

Fix compiler warnings (gcc: -Wsign-compare)
z4kn4fein · Apr 14, 2023 · 695f77f · 695f77f
2 parents ff29043 + 37b994d
commit 695f77f
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/include/semver/semver.hpp b/include/semver/semver.hpp
@@ -142,7 +142,7 @@ namespace semver
         prerelease_descriptor increment() const {
             std::vector<prerelease_part> new_parts = (m_parts);
             int last_numeric_index = -1;
-            for (int i = 0; i < new_parts.size(); ++i) {
+            for (size_t i = 0; i < new_parts.size(); ++i) {
                 if (new_parts[i].numeric()) last_numeric_index = i;
             }
             if (last_numeric_index != -1) {
@@ -159,7 +159,7 @@ namespace semver
             auto other_size = other.m_parts.size();
 
             auto count = std::min(this_size, other_size);
-            for (int i = 0; i < count; ++i) {
+            for (size_t i = 0; i < count; ++i) {
                 int cmp = m_parts[i].compare(other.m_parts[i]);
                 if (cmp != 0) return cmp;
             }
@@ -370,4 +370,4 @@ namespace semver
     }
 }
 
-#endif // Z4KN4FEIN_SEMVER_H
+#endif // Z4KN4FEIN_SEMVER_H