build(deps): bump r0adkll/upload-google-play from 1.1.2 to 1.1.3 #668
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [r0adkll/upload-google-play](https://github.com/r0adkll/upload-google-play) from 1.1.2 to 1.1.3. - [Release notes](https://github.com/r0adkll/upload-google-play/releases) - [Commits](r0adkll/upload-google-play@v1.1.2...v1.1.3) --- updated-dependencies: - dependency-name: r0adkll/upload-google-play dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
|
The following labels could not be found: |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -122,7 +122,7 @@ jobs: | |||
| UPLOAD_KEY_PASSWORD: ${{secrets.UPLOAD_KEY_PASSWORD}} | |||
| - name: Publish premium to google play | |||
| if: github.ref == 'refs/heads/develop' | |||
| uses: r0adkll/[email protected].2 | |||
| uses: r0adkll/[email protected].3 | |||
| continue-on-error: true | |||
| with: | |||
| serviceAccountJsonPlainText: ${{ secrets.SERVICE_ACCOUNT_JSON_PLAIN_TEXT }} | |||
There was a problem hiding this comment.
In the provided code patch, there are two changes:
-
The version of the "r0adkll/upload-google-play" action is updated from v1.1.2 to v1.1.3 in both blocks.
-
The condition for executing the "Publish premium to google play" step is incorrectly set to
github.ref == 'refs/heads/develop'instead of the intended condition. It should be updated with the appropriate branch name or condition.
Improvement suggestions:
-
The
continue-on-error: trueflag is used for both steps, which means that if an error occurs, the workflow will continue executing the subsequent steps. Consider whether this behavior aligns with your requirements. -
Ensure that the secrets (
UPLOAD_KEY_PASSWORDandSERVICE_ACCOUNT_JSON_PLAIN_TEXT) are properly configured and managed securely. Verify that they are correctly set up and accessible in the workflow environment. -
Review other parts of the codebase outside this code patch as well. This code patch appears to be part of a larger workflow file. Perform a holistic review to ensure consistency and correctness across the entire workflow.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #668 +/- ##
=============================================
+ Coverage 69.36% 69.38% +0.02%
Complexity 596 596
=============================================
Files 82 82
Lines 4410 4410
Branches 527 527
=============================================
+ Hits 3059 3060 +1
+ Misses 1018 1016 -2
- Partials 333 334 +1 ☔ View full report in Codecov by Sentry. |
Bumps r0adkll/upload-google-play from 1.1.2 to 1.1.3.
Release notes
Sourced from r0adkll/upload-google-play's releases.
Commits
935ef9cUpdate dependencies & target node20 (#212)84ffa89Bump tj-actions/verify-changed-files in /.github/workflows (#206)b6837faAdd instructions to configure service account in README (#201)7c9dfbbBump@babel/traversefrom 7.19.6 to 7.23.2 (#198)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)