feat: implements customizable alarm vibration #613
Conversation
app/src/main/java/com/better/alarm/presenter/AlarmDetailsFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/better/alarm/presenter/AlarmDetailsFragment.kt
Outdated
Show resolved
Hide resolved
According to me Vibrate preference in settings can be removed, as individual alarms will have there own vibrate preference now.
As of now, the default value for this new checkbox is set to true
I don't think any additional changes are required in |
|
Hi @yuriykulikov, I have made the changes which you mentioned. Please have a look. |
|
It seems to me that keeping the preference would be better. Probably in a different form. What do you think about the following: Create a new vibration preference with 3 possible values:
Another possibility would be to treat the value in settings as the default for newly created alarms |
|
@the-mr17 also please have a look at https://github.com/yuriykulikov/AlarmClock/blob/develop/app/src/main/java/com/better/alarm/background/VibrationPlugin.kt#L36 |
I am planning to implement this one. |
|
@yuriykulikov I have implemented the new vibration preference. Please have a look. 
|
| @@ -35,8 +35,11 @@ class VibrationPlugin( | |||
| Observable.combineLatest( | |||
| vibratePreference, | |||
| targetVolume, | |||
| BiFunction<Boolean, TargetVolume, TargetVolume> { isEnabled, volume -> | |||
| if (isEnabled) volume else TargetVolume.MUTED | |||
| BiFunction<String, TargetVolume, TargetVolume> { vibrate, volume -> | |||
There was a problem hiding this comment.
Try testing this. From the code alone I assume that changing the value for an alarm will not have any effect on the vibration, because here you evaluate only the global setting. I think alarm: PluginAlarmData, should contain the data you need to decide per alarm.
There was a problem hiding this comment.
I have tested it on a physical device, it works well.
There was a problem hiding this comment.
Ok, let's walk through the code.
Given
The preference value is "on"
And alarm checkbox is not checked
When
Alarm fires
Then
What is expected?
What actually happens?
There was a problem hiding this comment.
I am a bit confused over here. Can you please guide me, exactly what needs to be done here.
There was a problem hiding this comment.
what needs to be done here
You have to walk through the code as if you are Android. You can try writing comments on each like. Repeat this process 6 times for this particular function with different input parameters:
- Setting on & alarm vibrate on
- Setting on & alarm vibrate off
- Setting off & alarm vibrate on
- Setting off & alarm vibrate off
- Setting alwaysOff & alarm vibrate on
- Setting alwaysOff & alarm vibrate off
app/src/main/java/com/better/alarm/presenter/AlarmDetailsFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/better/alarm/presenter/AlarmsListActivity.kt
Outdated
Show resolved
Hide resolved
| <item>Always Off</item> | ||
| <item>On (by default)</item> | ||
| <item>Off (by default)</item> |
There was a problem hiding this comment.
Could you please add translations for German, Spanish, Italian, Norwegian, Russian and Ukranian? You can use ChatGPT for this, like this:
Please translate into German, Spanish, Italian, Norwegian, Russian and Ukranian:
<string name="vibration_title">Vibration</string>
<string-array name="vibration_entries">
<item>On by default</item>
<item>Off by default</item>
<item>Disabled</item>
</string-array>
This also is not very intuitive, so probably we should carefully explain to the user what is the deal here.
There was a problem hiding this comment.
Could you please add translations for German, Spanish, Italian, Norwegian, Russian and Ukranian? You can use ChatGPT for this, like this:
Sure, I am adding the translations of those languages.
This also is not very intuitive, so probably we should carefully explain to the user what is the deal here.
Can you please say more on how can I do this?
Fixes #470
This adds a feature to enable or disable vibration of any individual alarm.