Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BACKPORT 2.6][platform] Restart pod if the configuration changes #79

Open
wants to merge 1 commit into
base: 2.6
Choose a base branch
from

Commits on Jun 25, 2021

  1. [BACKPORT 2.6][platform] Restart pod if the configuration changes

    - This adds checksum of the configs.yaml file to pod metadata as
      annotation. This causes it to change if there are any changes in the
      configuration, and results in a restart of the pod.
      https://helm.sh/docs/howto/charts_tips_and_tricks/#automatically-roll-deployments
    - Moving the global-config outside from configs.yaml, as it has a
      random string in it, which causes a restart everytime as the
      checksum keeps changing.
    
    Test plan:
    - Deployed platform chart in a Kubernetes cluster without this change.
    - Upgraded the Helm release with this change (the pod restarts as
      expected).
    - Add --set helm.timeout=1000 during the helm upgrade (the pod
      restarts as expected)
    - Did another upgrade with same command as above (the pod does not
      restart as the configuration is the same).
    
    Signed-off-by: Bhavin Gandhi <[email protected]>
    bhavin192 committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    7f52439 View commit details
    Browse the repository at this point in the history