Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop mounting thirdparty deps during helm deployment #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

daniel-yb
Copy link
Contributor

Since we now rollup thirdparty deps in YW image, we shouldn't mount thirdparty volume from thirdparty-deps image during deployments

@iSignal
Copy link
Contributor

iSignal commented Sep 22, 2020

Looks good, can you add a test plan? Might be worth testing an upgrade scenario?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants