Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for local Swift packages in Xcode 15 #1465

Merged

Conversation

kinnarr
Copy link
Contributor

@kinnarr kinnarr commented Apr 11, 2024

This add support for local Swift packages in Xcode 15 and solves #1396

Copy link
Owner

@yonaskolb yonaskolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @kinnarr. Could you also test the creation of these in the local packages test here

$0.it("generates local swift packages") {

Copy link
Owner

@yonaskolb yonaskolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add the tests here

@kinnarr
Copy link
Contributor Author

kinnarr commented Jul 11, 2024

Oh, sorry. I had a quick look into the tests, but got other work to do and totally forgot about the pr 🙈

Thanks for completing it 😃

@yonaskolb
Copy link
Owner

All good, thanks for adding this

@yonaskolb yonaskolb merged commit 5af3bf3 into yonaskolb:master Jul 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants