Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent logging error when anki is disconnected #843

Merged
merged 2 commits into from
Apr 20, 2024

Conversation

StefanVukovic99
Copy link
Collaborator

@StefanVukovic99 StefanVukovic99 commented Apr 19, 2024

Should fix #825.

@StefanVukovic99 StefanVukovic99 requested a review from a team as a code owner April 19, 2024 18:27
Copy link

github-actions bot commented Apr 19, 2024

✔️ No visual differences introduced by this PR.

View Playwright Report (note: open the "playwright-report" artifact)

@StefanVukovic99 StefanVukovic99 changed the title Revert "log anki error when hiding button (#821)" Prevent logging error when anki is disconnected Apr 19, 2024
Copy link
Member

@Kuuuube Kuuuube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works. Tested on Chromium 122.0.6261.128.

@Kuuuube Kuuuube added kind/bug The issue or PR is regarding a bug area/anki The issue or PR is related to Anki integration labels Apr 20, 2024
@jamesmaa jamesmaa added this pull request to the merge queue Apr 20, 2024
Merged via the queue into yomidevs:master with commit d34feb3 Apr 20, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/anki The issue or PR is related to Anki integration kind/bug The issue or PR is regarding a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Yomitan spitting out errors when Anki is not opened
3 participants