-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Annotation-powered method registration #71
base: master
Are you sure you want to change the base?
Conversation
Fixed the existing tests; this still needs coverage for annotation discovery and fixing the scrutinizer test. |
This now fails due to maglnet/ComposerRequireChecker#65 - I would suggest that phpstan is probably better at performing this type of static analysis. |
Hello 👋 , first of all, thanks a lot for your contribution, I really appreciate it. I agree regarding PHPStan (there is already an issue opened for that), unfortunately I have no time for the moment to add it and fix every violations it will report (I already started on another project but not finish it yet). Apart that, your code looks good (I will add some comments regarding tiny things to update), it just miss (as you mentioned) UT for new case and a functional test 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Globally LGTM, some small updates to do.
+missing UT and FT
Feel free to ping me in case I don't give reviews, as said, I'm a little bit busy and might miss some notifications ;)
Any update? |
@tourze Everyone here is volunteering their time. Perhaps you could help with a unit or functional test? |
Closes #70