Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotation-powered method registration #71

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

bradjones1
Copy link

Closes #70

@bradjones1 bradjones1 requested a review from yoanm as a code owner May 20, 2021 01:37
@bradjones1
Copy link
Author

Fixed the existing tests; this still needs coverage for annotation discovery and fixing the scrutinizer test.

@bradjones1
Copy link
Author

This now fails due to maglnet/ComposerRequireChecker#65 - I would suggest that phpstan is probably better at performing this type of static analysis.

@yoanm
Copy link
Owner

yoanm commented May 20, 2021

Hello 👋 , first of all, thanks a lot for your contribution, I really appreciate it.

I agree regarding PHPStan (there is already an issue opened for that), unfortunately I have no time for the moment to add it and fix every violations it will report (I already started on another project but not finish it yet).
Meanwhile, did you tried what is suggested on the issue you mentioned ? (adding use function class_exists; on top of the file)

Apart that, your code looks good (I will add some comments regarding tiny things to update), it just miss (as you mentioned) UT for new case and a functional test 👍

Copy link
Owner

@yoanm yoanm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Globally LGTM, some small updates to do.
+missing UT and FT

Feel free to ping me in case I don't give reviews, as said, I'm a little bit busy and might miss some notifications ;)

@tourze
Copy link

tourze commented May 28, 2022

Any update?

@bradjones1
Copy link
Author

@tourze Everyone here is volunteering their time. Perhaps you could help with a unit or functional test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for method registration via annotation (similar to routes)
3 participants