Coveringnetworks #47
Open
Coveringnetworks #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coveringOrCoveredNetworks() This allows for test cases to be written in the usual way, which I have now rewritten
|
@yl2chen, after I opened PR #47, I noticed there was another PR with the exact same name (PR #43), which is still open (oups). Re your comment in PR #47, I did test your code suggestion, but with my own PR, with the following line: My tests failed. In test case TestPrefixTrieCoveringNetworks/path_not_taken, CoveringNetworks("192.168.0.0/16") returns "192.168.0.0/24" but shouldn't. I'm open to adjustments and to discussion. -Hidden |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addition of the CoveringNetworks() and CoveringOrCoveredNetworks() methods. I'm certainly open to better name choices if you have something better in mind.
This lib is useful to me and I use these additions, especially CoveringOrCoveredNetworks(). I'm happy if they can benefit others too.
-Hidden