fix: correlation auto passing extra parameters (#1114)

* fix: correlation `auto` passing extra parameters * fix: Remove debugger trace Co-authored-by: Alexandre Quemy <[email protected]>
ydataai · Oct 20, 2022 · 21f4fe6 · 21f4fe6
1 parent c2f817d
commit 21f4fe6
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/src/pandas_profiling/model/correlations.py b/src/pandas_profiling/model/correlations.py
@@ -25,7 +25,7 @@ class Auto(Correlation):
  @staticmethod
  @multimethod
  def compute(
- config: Settings, df: Sized, summary: dict, n_bins: int
+ config: Settings, df: Sized, summary: dict
  ) -> Optional[Sized]:
  raise NotImplementedError()
 

diff --git a/src/pandas_profiling/model/pandas/correlations_pandas.py b/src/pandas_profiling/model/pandas/correlations_pandas.py
@@ -156,12 +156,11 @@ def pandas_phik_compute(
  return correlation
 
 
-@Auto.compute.register(Settings, pd.DataFrame, dict, int)
+@Auto.compute.register(Settings, pd.DataFrame, dict)
 def pandas_auto_compute(
  config: Settings,
  df: pd.DataFrame,
- summary: dict,
- n_bins: int = 10,
+ summary: dict
 ) -> Optional[pd.DataFrame]:
  threshold = config.categorical_maximum_correlation_distinct
 
@@ -175,7 +174,7 @@ def pandas_auto_compute(
  and value["n_distinct"] <= threshold
  ]
  df_discretized = Discretizer(
- DiscretizationType.UNIFORM, n_bins=n_bins
+ DiscretizationType.UNIFORM, n_bins=config.correlations["auto"].n_bins
  ).discretize_dataframe(df)
  columns_tested = numerical_columns + categorical_columns
  correlation_matrix = pd.DataFrame(