Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set is_default_rule and OD_RULE_POOL_CLIENT_VISIBLE for group_rule #689

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

aidekqz
Copy link
Contributor

@aidekqz aidekqz commented Sep 18, 2024

config

...
database default {
    group "group1" {
        authentication "md5"
        auth_query "SELECT usename, passwd FROM pg_shadow WHERE usename=$1"
        auth_query_user "postgres"
        auth_query_db "postgres"
        storage "postgres_server"
        pool "transaction"
        group_query "SELECT rolname FROM pg_roles WHERE pg_has_role(rolname, 'group1', 'member')"
        group_query_user "postgres"
        group_query_db "postgres"
    }
}

database default {
    group "group1" {
        authentication "md5"
        auth_query "SELECT usename, passwd FROM pg_shadow WHERE usename=$1"
        auth_query_user "postgres"
        auth_query_db "postgres"
        storage "postgres_server"
        pool "transaction"
        group_query "SELECT rolname FROM pg_roles WHERE pg_has_role(rolname, 'group1', 'member')"
        group_query_user "postgres"
        group_query_db "postgres"
    }
}

database default {
    user default {
        authentication "md5"
        auth_query "SELECT usename, passwd FROM pg_shadow WHERE usename=$1"
        auth_query_user "postgres"
        auth_query_db "postgres"
        storage_password "..."
        storage "postgres_server"
        pool "transaction"
    }
}

expect

yarchirkov@test-instance:~/odyssey_group$ ./binary/odyssey ./config_group.conf
23714 2024-09-17T20:09:02Z info (startup) none Starting Odyssey
23714 2024-09-17T20:09:02Z error (config) none route 'group_group1.group_group1': is redefined

got: odyssey has started and contains duplicates of group_rules

order   auth    db_name     user_name       obsolete        mark    refs    group                   is_default      online_if_group
0       md5     default_db  group_group1    is_obsolete=0   mark=0  refs=0  group=0x557f9bed83d0    db_is_default=0 online=1
0       md5     default_db  group_group1    is_obsolete=0   mark=0  refs=0  group=0x557f9bed9730    db_is_default=0 online=1
0       md5     default_db  default_user    is_obsolete=0   mark=0  refs=0  group=(nil)             db_is_default=1
0       (null)  default_db  default_user    is_obsolete=0   mark=0  refs=1  group=(nil)             db_is_default=1

@aidekqz
Copy link
Contributor Author

aidekqz commented Sep 18, 2024

checks failed
fix: #690

@reshke
Copy link
Contributor

reshke commented Sep 18, 2024

rebase on master plz

@reshke reshke merged commit a0f5ec5 into yandex:master Sep 18, 2024
1 check passed
@aidekqz aidekqz deleted the fix_group_rules_default_rule branch September 25, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants