Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Group address range + fix tail data #673

Merged
merged 7 commits into from
Aug 27, 2024
Merged

Group address range + fix tail data #673

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1793455
Parse address func + group address
visill Aug 25, 2024
dfb86c9
fmt
visill Aug 25, 2024
d5ad357
test
visill Aug 25, 2024
0c189f7
fix
visill Aug 26, 2024
7340ba2
or or and thats question
visill Aug 26, 2024
f60f834
second fix
visill Aug 26, 2024
d69c365
fmt
visill Aug 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sources/group.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ int od_group_parse_val_datarow(machine_msg_t *msg, char **group_member)
goto error;
}

*group_member = strdup(pos);
*group_member = strndup(pos, val_len);
if (*group_member == NULL) {
goto error;
}
Expand Down
3 changes: 3 additions & 0 deletions sources/rules.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,6 +360,9 @@ void od_rules_group_checker_run(void *arg)
usernames[j] = member_name->value;
j++;
}
od_debug(&instance->logger, "group_checker",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

это не дебажное логгирование осталось?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Вообще оно полезное, но его и то что пониже можно убрать

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Я еще дебажные галки не убрал

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Хотя когда тесты падают будет сразу видна дебажная инфа

group_checker_client, server, "%d",
count_group_users);
for (int k = 0; k < count_group_users; k++) {
od_debug(&instance->logger, "group_checker",
group_checker_client, server,
Expand Down
Loading