mdb iamproxy auth support #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
January 26, 2024 13:03
x4m
reviewed
Jan 29, 2024
sources/mdb_iamproxy.c
Outdated
| uint64_t msg_size = sizeof(body_size) + body_size; | ||
| uint64_t sent = 0; // stores byte-size of sended info | ||
| char *msg = (char *)calloc( | ||
| msg_size, sizeof(*msg)); // allocate memory for msg buffer |
There was a problem hiding this comment.
sizeof(char) == 1 by C standard
There was a problem hiding this comment.
Yes, but what's incorrect here? i think it's common to allocate dynamic memory in that way
type *mem = calloc(n, sizeof(*mem)); its easily to read, and remove nubmers/random (for common code reader) constants from code
But if necessary, I can fix it
added 10 commits
January 29, 2024 11:12
mialinx
reviewed
Feb 1, 2024
sources/auth.c
Outdated
| msg = od_read(&client->io, UINT32_MAX); | ||
| if (msg == NULL) { | ||
| od_error(&instance->logger, "auth", client, NULL, | ||
| "fuck that shit again"); |
There was a problem hiding this comment.
be polite, the Internet remembers all
mialinx
reviewed
Feb 1, 2024
mialinx
reviewed
Feb 1, 2024
mialinx
reviewed
Feb 1, 2024
mialinx
reviewed
Feb 1, 2024
mialinx
reviewed
Feb 1, 2024
mialinx
reviewed
Feb 1, 2024
mialinx
reviewed
Feb 1, 2024
mialinx
reviewed
Feb 1, 2024
reshke
reviewed
Feb 1, 2024
added 7 commits
February 1, 2024 21:50
…in od_log at the end of mdb_iamproxy_authenticate_user
x4m
approved these changes
Feb 5, 2024
| } |
| #define MDB_IAMPROXY_DEFAULT_SOCKET_FILE \ | ||
| "/var/run/iam-auth-proxy/iam-auth-proxy.sock" // PAM SOCKET FILE place | ||
|
|
||
| void put_header(char dst[], uint64_t src) |
There was a problem hiding this comment.
let's mark these as static.
Generaly we do all the formatting stuff in KiWi... it's kind of byte-formatting lib.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.