chore: refactor dns #250
Open
chore: refactor dns #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 18, 2024 04:07
| enableDOH, | ||
| ), | ||
| ) | ||
| return dnshandler.Apply(factoryResolver, dnshandler.NewLoggingHandler(), dnshandler.NewErrorHandler()) |
There was a problem hiding this comment.
To add cross-cutting logic, need to add a handler implementation to this chain.
Handlers applies in given order
|
@LiquidTheDangerous, pinging you in case you haven't seen the code comments yet. They don't update comment counter, it seems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A minor refactoring of the DNS functionality has been completed. The dns.Resolve function had an unclear interface and primarily handled cross-cutting concerns (such as logging and error handling). A new entity, the DNS handler, has been introduced to manage these cross-cutting concerns. The advantage of this approach is the ability to dynamically add new cross-cutting logic (for example, dns caching) simply by adding a new handler to the chain. Please take a look.