Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use XTENSOR_DEFAULT_ALIGNMENT when using XSIMD #2739

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

spectre-ns
Copy link
Contributor

@spectre-ns spectre-ns commented Nov 6, 2023

Checklist

  • [ x] The title and commit message(s) are descriptive.
  • [ x] Small commits made to fix your PR have been squashed to avoid history pollution.
  • [ x] Tests have been added for new features or bug fixes.
  • [ x] API of new functions and classes are documented.

Description

Updated to allow overriding of alignment when using XSIMD. If the user doesn't provide an overriding value then the default XSIMD value is used. This fixed linker issues when different default vectorization settings are used between libraries within the same project. The intel C++ compiler requests 16 alignment for AVX while MSVC defines it to 32 so it's nice to be able to pin the alignment at the higher of the two.

Updated to allow overriding of alignment
@JohanMabille
Copy link
Member

Thanks!

@JohanMabille JohanMabille merged commit 34cd549 into xtensor-stack:master Nov 6, 2023
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants