-
-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
miniaudio: Add support for split version and expose extra/nodes #5686
Conversation
SirLynix
commented
Nov 6, 2024
- Before adding new features and new modules, please go to issues to submit the relevant feature description first.
- Write good commit messages and use the same coding conventions as the rest of the project.
- Please commit code to dev branch and we will merge into master branch in feature
- Ensure your edited codes with four spaces instead of TAB.
- 增加新特性和新模块之前,请先到issues提交相关特性说明,经过讨论评估确认后,再进行相应的代码提交,避免做无用工作。
- 编写友好可读的提交信息,并使用与工程代码相同的代码规范,代码请用4个空格字符代替tab缩进。
- 请提交代码到dev分支,如果通过,我们会在特定时间合并到master分支上。
- 为了规范化提交日志的格式,commit消息,不要用中文,请用英文描述。
why doesn't it build as an objc file? (-fobjc flag) |
package:has_cfuncs only check code snippet as c code, not objc code. but |
it fails in on_install, when compiling miniaudio.c which should be treated as an objective C file on iOS, which is why I used add_files("extras/miniaudio_split/miniaudio.c", {sourcekind = "mm"}) but xmake still doesn't pass the -fobjc flag, how to make xmake treat miniaudio.c like an .m file? |
you can use os.mv to rename it in on_install |
I will do that, but does it mean sourcekind is broken for add_files? |
any reason this doesn't work? I found it in another package: on_load(function (package)
if package:config("headeronly") then
package:set("kind", "library", {headeronly = true})
end
end) |
nvm I just noticed I have two on_load functions 😓 |