verilator: switch to cmake #5680
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waruqi
reviewed
Nov 6, 2024
star-hengxing
force-pushed
the
verilator-cmake
branch
from
0d632d8
to
fe82a05
Compare
waruqi
reviewed
Nov 12, 2024
| @@ -40,6 +36,7 @@ package("bison") | |||
| end) | |||
|
|
|||
| on_install("@msys", function (package) | |||
| os.vrun("pacman -Sy --noconfirm --needed --disable-download-timeout bison") | |||
There was a problem hiding this comment.
包配置里，不要直接调用 pacman/apt 等系统安装，会有权限问题，走 xmake 内置安装，而且你这么装，会装到系统路径，不是 包安装目录，会 break 掉 xrepo env
There was a problem hiding this comment.
而 xmake 内部调用 pacman 会有对权限的很多处理，这里不能这么搞，如果源码安装不行，宁愿禁用这个平台
There was a problem hiding this comment.
这个是 msys2 包，用 add_deps 会加上 mingw 前缀导致安装失败
waruqi
reviewed
Nov 12, 2024
| @@ -35,6 +40,13 @@ package("flex") | |||
| end) | |||
|
|
|||
| on_install("@msys", function (package) | |||
| os.vrun("pacman -Sy --noconfirm --needed --disable-download-timeout flex") | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.