Python: If headeronly is set, links is not needed #5403
Conversation
|
不要提交到 master，我默认分支都切到 dev 了，就是为了避免误提交，怎么还往 master 提 |
Don't submit to master. By default, I have switched branches to dev just to avoid mistaken submissions. Why do I still submit to master? |
|
因为那个 fork 是很早做的, 还在 master. 已经修改到了 dev |
Because that fork was done very early and is still on master |
|
不要带中文 commit |
Don’t bring Chinese commit |
packages/p/pybind11/xmake.lua
Outdated
| local python_headeronly = package:config("python_headeronly") | ||
| if is_host("windows") then | ||
| wprint("Python headeronly is not supported on Windows") | ||
| python_headeronly = false |
There was a problem hiding this comment.
如果 windows 不支持，应该 add_configs 时候，直接设置为 readonly = true, default = false 锁定住，原本就会自动给 warning 。。不用额外检测
There was a problem hiding this comment.
这个我不太清楚怎么做到，add_configs能对不同的操作系统限制吗？Linux 下，如果想要嵌入，还是要 link Python 的
There was a problem hiding this comment.
参考下。
if is_plat("windows", "mingw") then
-- Do not build static library for window.
add_configs("shared", {description = "Build shared library.", default = true, type = "boolean", readonly = true})
add_configs("vs_runtime", {description = "Set vs compiler runtime.", default = "MD", readonly = true})
end
Linking libpythonX.Y.so is not allowed on manylinux. So I change the Python fetch logic to allow building without libdir on manylinux.
#5391