Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Appdata and translation related patches #49

Closed
wants to merge 9 commits into from
Closed

Draft: Appdata and translation related patches #49

wants to merge 9 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Nov 27, 2023

  • Add translator-credits support
  • Fix a few appdata strings
  • Update the POT file

I coldn't build the patch (yet)

Sabri Ünal added 9 commits November 27, 2023 10:02
Translators can be shown on About dialog
Can be used to create a POT file.
- Update content_rating version
- Add the bugtracker, vcs_browser and translation URLs
- Fix release indents
- Move down the launchable tag
Make the first sentence shorter.
I used the following command:

xgettext --files-from=po/POTFILES --output=po/blue-recorder.pot --from-code=UTF-8 --package-name=Blue\ Recorder --copyright-holder=Blue\ Recorder --add-comments
@xlmnxp
Copy link
Owner

xlmnxp commented Nov 27, 2023

Can you tell me what issue you facing in building of Blue Recorder?

@ghost
Copy link
Author

ghost commented Nov 27, 2023

Translations seem missing. UI seem untranslated.

@xlmnxp
Copy link
Owner

xlmnxp commented Nov 29, 2023

Translations seem missing. UI seem untranslated.

correct, we are facing some issues with gettext
#10

@ghost
Copy link
Author

ghost commented Nov 29, 2023

There was no translation and no activity related to translated po files. I'm not expert on Meson but there is no meson file to build the po files.

amberol
meson.build file
in main folder: https://gitlab.gnome.org/World/amberol/-/blob/main/meson.build?ref_type=heads
in po directory: https://gitlab.gnome.org/World/amberol/-/blob/main/po/meson.build?ref_type=heads
gettext binding: https://gitlab.gnome.org/World/amberol/-/blob/main/src/main.rs?ref_type=heads#L44

@xlmnxp
Copy link
Owner

xlmnxp commented Nov 29, 2023

we don't need meson, cargo handle the build process

@ghost
Copy link
Author

ghost commented Nov 29, 2023

Sorry. My knowledge is limited. Thanks for your pation.

@ghost ghost closed this Nov 29, 2023
@ghost
Copy link
Author

ghost commented Nov 29, 2023

simple version of this patch: #51

@ghost ghost deleted the fix-translation branch November 29, 2023 05:39
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant