Update clap to v4.5 #3396
Merged
Update clap to v4.5 #3396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was previously locked to 4.4 due to MSRV incompatibilities which are now resolved.
shssoichiro
force-pushed
the
update-clap
branch
from
0ffb09f
to
3823f4a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3396 +/- ##
==========================================
- Coverage 88.52% 82.14% -6.39%
==========================================
Files 89 89
Lines 28323 27408 -915
==========================================
- Hits 25074 22515 -2559
- Misses 3249 4893 +1644 ☔ View full report in Codecov by Sentry. |
shssoichiro
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was locked to 4.4.17 because of MSRV incompatibilities. #3359 ultimately decided to bump the MSRV to 1.74 which is enough for clap 4.5, so I unlock and update it here.
The only remaining locked dependency is
bitstream-io, which now has an MSRV of 1.79.