Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the new interface of danmaku_live #164

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

lanytcc
Copy link
Contributor

@lanytcc lanytcc commented Jul 12, 2023

更改了发送心跳包的逻辑,目前测试没有问题。

接口同#161

@lanytcc lanytcc changed the title Improve the new interface of barrage Improve the new interface of danmaku Jul 12, 2023
@lanytcc lanytcc changed the title Improve the new interface of danmaku Improve the new interface of danmaku_live Jul 12, 2023
@xfangfang
Copy link
Owner

@maye174 感谢,我稍后研究一下看看~

@lanytcc
Copy link
Contributor Author

lanytcc commented Jul 18, 2023

pr一直没合并,遇到什么困难了吗?

@xfangfang
Copy link
Owner

感谢支持关注,我上个周末意外遇到点别的事,所以没抽出时间来研究直播弹幕的部分。
mongoose这个 DNS timeout的问题在我这里还是有,我想先解决这个问题,再处理直播弹幕的内容。

@xfangfang xfangfang merged commit be85288 into xfangfang:fix_live Jul 21, 2023
11 checks passed
xfangfang added a commit that referenced this pull request Jul 21, 2023
* Fix the live activity crash (#159)

* Improve the new interface of barrage (#164)

---------

Co-authored-by: Maye <[email protected]>
@xfangfang
Copy link
Owner

@maye174 合并进dev分支了,并修复了一点小问题:

  1. heartbeat_thread 一直在运行,因此 LiveDanmaku 在析构函数运行结束后会导致应用报错,我把这个改为了使用 mg_timer_add 来运行
  2. ws_utils 里面 parse_packet 使用了 reinterpret_cast 来转换 uint32_t/uint16_t,这几个转换会在gdb调试时报 "Undefined Behavior",(可能是防止出现类型对齐问题所以强制提示的?)我给换了种写法。
  3. 之前我遇到的 DNS 问题是 mongoose 的原因,他在一个域名对应IP数大于10时认为解析失败了,我把这个数简单地改成了20 (希望不会有别的问题)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants