feat: add --no-upgrade flag #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noqcks
reviewed
May 8, 2024
apps/cli/src/App.tsx
Outdated
| @@ -254,6 +255,7 @@ const App = (props: { | |||
| "-p", | |||
| `${port}`, | |||
| ...(token ? ["-t", token] : []), | |||
| ...(props.upgrade ? [] : ["-n"]), | |||
There was a problem hiding this comment.
does upgrade need to come before token in the args?
There was a problem hiding this comment.
they're flags so it shouldn't matter
| .option("-s, --simple", "simple mode") | ||
| .option("-i, --ipc", "run in ipc mode") | ||
| .parse(); | ||
|
|
||
| const { model, language, port, ipc, simple, token } = command.opts(); | ||
| const { model, language, port, ipc, simple, token, upgrade } = command.opts(); |
There was a problem hiding this comment.
wouldn't it be noUpgrade or something?
There was a problem hiding this comment.
commander is smart enough to handle this automatically
There was a problem hiding this comment.
the types work automatically too (it parses the string)
noqcks
approved these changes
May 9, 2024
zlalvani
force-pushed
the
zlalvani/skip-upgrade-flag
branch
from
4eb323b
to
f7528df
Compare
noqcks
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful in cases where you use a different tool to perform the upgrade, or you did it manually