Publish to npm on PR tags #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shihanwan
commented
Apr 17, 2024
.github/workflows/ci.yml
Outdated
| - name: Setup | ||
| uses: ./tooling/github/setup | ||
|
|
||
| - name: Copy env |
There was a problem hiding this comment.
@zlalvani do we even have a .env file for this repo?
shihanwan
force-pushed
the
publish-to-npm
branch
2 times, most recently
from
731a34d
to
11808b0
Compare
shihanwan
requested review from
noqcks and
zlalvani
and removed request for
noqcks
noqcks
reviewed
Apr 24, 2024
.github/workflows/publish-npm.yml
Outdated
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - uses: pnpm/action-setup@v2 |
There was a problem hiding this comment.
should it be this?
- name: Setup
uses: ./tooling/github/setup
noqcks
reviewed
Apr 24, 2024
.github/workflows/publish-npm.yml
Outdated
|
|
||
| - name: 🚀 Publish to npm | ||
| shell: bash | ||
| run: pnpm publish apps/cli |
There was a problem hiding this comment.
need to publish bumpgen-core as well?
There was a problem hiding this comment.
Should we publish both separately then?
There was a problem hiding this comment.
yes, they should be separate
There was a problem hiding this comment.
are they going to be published at the same time or should we have 2 publish workflows, one for cli one for core?
shihanwan
force-pushed
the
publish-to-npm
branch
from
37c5e2e
to
d65fc26
Compare
zlalvani
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.