Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XCD-144 Fix shaking measurement #1719

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MichalDybizbanskiCreoox
Copy link
Collaborator

Not sure what was the original intention to hide measurement controls when camera was too close to them, but it causes glitches as described at https://creoox.atlassian.net/browse/XCD-175?focusedCommentId=13492
Removing this special logic seems to fix the reported issue.

@xeolabs
Copy link
Member

xeolabs commented Oct 31, 2024

With this PR, what is the behaviour of measurent controls when they intersect the front clipping plane?

@MichalDybizbanskiCreoox
Copy link
Collaborator Author

The lines are visible even when they are "behind" the camera, which is no good I guess.
The opposite is not good either though, because if one end of a line is behind the camera, but the other is in front of it, a part of the line should be visible, but that's tricky to achieve with DOM elements.

@MichalDybizbanskiCreoox MichalDybizbanskiCreoox marked this pull request as draft October 31, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants