Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yaml: move common_data inside the build directory #117

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rshym
Copy link
Collaborator

@rshym rshym commented Oct 30, 2024

All common data should be kept inside the build folder.

@rshym rshym linked an issue Oct 30, 2024 that may be closed by this pull request
@Deedone
Copy link
Contributor

Deedone commented Oct 30, 2024

I strongly disagree with the statement that it is better to build with separate caches. As we frequently build multiple images that are very similar to each other, removing the shared cache can worsen build times a lot without giving any clear benefit. I propose to keep it but place it at a new location similar to how downloads dir is moved.

Alternatively, if we really want to do clean builds, it would be nice to at least add moulin feature to automatically place the user's site.conf in every build directory.

@rshym rshym changed the title yaml: rework common_data yaml: move common_data inside the build directory Nov 1, 2024
@rshym
Copy link
Collaborator Author

rshym commented Nov 1, 2024

I strongly disagree with the statement that it is better to build with separate caches.

After reading related discussions I now agree with your point regarding state caches.
So, this PR now moves common_data inside the build directory, so all build-related stuff is created in the place, that is expected by the user.

@Deedone
Copy link
Contributor

Deedone commented Nov 1, 2024

Nice Acked-by: Mykyta Poturai <[email protected]>

All common data should be kept inside the build folder.

Signed-off-by: Ruslan Shymkevych <[email protected]>
Acked-by: Mykyta Poturai <[email protected]>
@rshym
Copy link
Collaborator Author

rshym commented Nov 1, 2024

Ack is added.
Ready to be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rework common_data
2 participants