[Session] Rework of ExtractStreamProtectionData #1659
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CastagnaIT
added
Type: Improvement
When init data or default KID is missing this change allow to extract it from mp4 box NOTE now this method is intended to never change the data from PSSHSets objects
its now taken from mp4box
CastagnaIT
force-pushed
the
default_kid_fallback
branch
from
16c2b81
to
e753b0d
Compare
CastagnaIT
force-pushed
the
default_kid_fallback
branch
from
e753b0d
to
439f525
Compare
|
a good start but are needs others improvements/cleanups |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This allow to get not only initdata when missing
but also the default KID when it is missing
from mp4 boxes
NOTE now this method is intended to never change the data from PSSHSets objects
Motivation and context
fix #1657
How has this been tested?
wait user feedback
Screenshots (if appropriate):
Types of change
Checklist: