Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Session] Rework of ExtractStreamProtectionData #1659

Closed
wants to merge 3 commits into from
Closed

[Session] Rework of ExtractStreamProtectionData #1659

wants to merge 3 commits into from

Conversation

CastagnaIT
Copy link
Collaborator

@CastagnaIT CastagnaIT commented Aug 26, 2024 •
edited
Loading

Description

This allow to get not only initdata when missing
but also the default KID when it is missing
from mp4 boxes

NOTE now this method is intended to never change the data from PSSHSets objects

Motivation and context

fix #1657

How has this been tested?

wait user feedback

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • I have read the Contributing document
  • My code follows the Code Guidelines of this project
  • My change requires a change to the Wiki documentation
  • I have updated the documentation accordingly

@CastagnaIT CastagnaIT added Type: Improvement non-breaking change which improves existing functionality v22 Piers labels Aug 26, 2024
@CastagnaIT
[Session] Rework of ExtractStreamProtectionData
25f92b1 
When init data or default KID is missing
this change allow to extract it from mp4 box

NOTE now this method is intended to never change the data from PSSHSets objects
@CastagnaIT
[DashTree] Removed clearkey KID workaround
e1690f5 
its now taken from mp4box
@CastagnaIT
Copy link
Collaborator Author

a good start but are needs others improvements/cleanups
so for now i close it

@CastagnaIT CastagnaIT closed this Aug 28, 2024
@CastagnaIT CastagnaIT deleted the default_kid_fallback branch August 29, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Type: Improvement non-breaking change which improves existing functionality v22 Piers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] ISA fails to play content with Widevine DRM
1 participant
@CastagnaIT