-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Kafka 3.0.0. #691
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Hermann Mayer <[email protected]>
Signed-off-by: Hermann Mayer <[email protected]>
Signed-off-by: Hermann Mayer <[email protected]>
@@ -8,27 +8,47 @@ testCreateTopics() { | |||
# TOPICS array contains the topic name to create / validate | |||
# CLEANUP array contains the expected cleanup policy configuration for the topic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to change this comment to CONFIG as well.
@wurstmeister what are your thoughts on this? |
@loop Can you fix the conflicts and bump to 3.0.1? Keen for a version with https://issues.apache.org/jira/browse/KAFKA-13636 fixed. |
@Jack12816 What is the plan for getting this over the finishline, potentially (preferred) bumping this to 3.1.0 |
I am working on getting this to work with 3.1.0, until now there is a few fixes that needs to be applied.. will get back in a few days once there is some news |
The tests for 3.0.0 still failed in the latest state of this PR. I was working on fixing this, but had no time since then to complete it. I'm also not sure whats the actual issue anymore :S |
Ok, I took the liberty of building on top of your work in my own fork. I managed to get the tests green.. I need the 3.x support for a project I am dooing.. So I am willing to try to get this support added to master herer (rather than have to maintain my own fork) |
Worth mentioning there are other Kafka images that already have 3.x releases |
- What is it good for
Support for Kafka 3.0.0 with the regular ZooKeeper setup.
- What I did
I just added Kafka 3.0.0 as build configuration just like Add support for Kafka 2.8.1 did. A local build was successful, even though I will play around with this locally. I also had to change some Kafka connection options (
--zookeeper
is deprecated since multiple versions, and since Kafka 3.0 it was removed -- replaced by the--bootstrap-server
option) and fix some tests for the new version/outputs.- A picture of a cute animal (not mandatory but encouraged)