Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #31 Force codeql analysis to use internal repos #32

Merged
merged 5 commits into from
Aug 15, 2023
Merged

Fix #31 Force codeql analysis to use internal repos #32

merged 5 commits into from
Aug 15, 2023

Conversation

jandusil
Copy link
Contributor

@jandusil jandusil commented Aug 8, 2023

  • Add JAVA_TOOL_OPTIONS for the codeql autobuild

@jandusil
Fix #31 Force codeql analysis to use internal repos
cebb384 
 - Add JAVA_TOOL_OPTIONS for the codeql autobuild
@jandusil jandusil self-assigned this Aug 8, 2023
@jandusil jandusil linked an issue Aug 8, 2023 that may be closed by this pull request
Force codeql analysis to use internal repos #31
Closed
@jandusil
Copy link
Contributor Author

jandusil commented Aug 8, 2023

Seems to be working properly, please see https://github.com/wultra/enrollment-server/actions/runs/5798127228/job/15715191882 for example

@jandusil jandusil requested a review from banterCZ August 8, 2023 14:28
banterCZ
banterCZ approved these changes Aug 9, 2023
View reviewed changes
Copy link
Member

@banterCZ banterCZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@jandusil jandusil marked this pull request as draft August 15, 2023 08:17
@jandusil
Fix #31 Force codeql analysis to use internal repos
cc36f90 
 - Add MAVEN_ARGS for the codeql autobuild
 - Add jfrog credentials
@jandusil
Fix #31 Force codeql analysis to use internal repos
0ad6150 
 - Add input for server-id
@jandusil
Fix #31 Force codeql analysis to use internal repos
b07d1c9 
 - Switch back to JAVA TOOL OPTIONS
@jandusil
Copy link
Contributor Author

Please check the run of the reviewed codeql parent

https://github.com/wultra/enrollment-server/actions/runs/5867402985

@jandusil jandusil marked this pull request as ready for review August 15, 2023 13:13
@jandusil
Copy link
Contributor Author

jandusil commented Aug 15, 2023 •
edited
Loading

Regarding this PR there must be changes made in several other repos and their codeql-analysis scripts respectively

  • enrollment-server PR
  • powerauth-server PR
  • lime-core-java PR

zcgandcomp
zcgandcomp approved these changes Aug 15, 2023
View reviewed changes
Copy link
Member

@zcgandcomp zcgandcomp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Secrets are propagated and JAVA_TOOL_OPTIONS seems to trigger proper profile

@jandusil jandusil merged commit 817ff85 into develop Aug 15, 2023
@jandusil jandusil deleted the issues/31-internal-repo-codeql branch August 15, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcgandcomp zcgandcomp zcgandcomp approved these changes

@banterCZ banterCZ banterCZ approved these changes

Assignees

@jandusil jandusil

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Force codeql analysis to use internal repos
3 participants
@jandusil @banterCZ @zcgandcomp