Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #86: Executable war #88

Merged
merged 3 commits into from
Oct 24, 2023
Merged

Fix #86: Executable war #88

merged 3 commits into from
Oct 24, 2023

Conversation

jandusil
Copy link
Contributor

No description provided.

@jandusil jandusil self-assigned this Oct 24, 2023
@jandusil jandusil temporarily deployed to docker-publish October 24, 2023 10:34 — with GitHub Actions Inactive
@jandusil jandusil linked an issue Oct 24, 2023 that may be closed by this pull request
Executable war #86
Closed
@jandusil jandusil temporarily deployed to docker-publish October 24, 2023 10:48 — with GitHub Actions Inactive
banterCZ
banterCZ approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@banterCZ banterCZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

banterCZ
banterCZ requested changes Oct 24, 2023
View reviewed changes
Copy link
Member

@banterCZ banterCZ left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it should be ideally in dependency management.

banterCZ
banterCZ approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@banterCZ banterCZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@jandusil jandusil merged commit 0a331e4 into develop Oct 24, 2023
5 checks passed
@jandusil jandusil deleted the issues/86-executable-war branch October 24, 2023 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@banterCZ banterCZ banterCZ approved these changes

Assignees

@jandusil jandusil

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Executable war
2 participants
@jandusil @banterCZ