Fix #174: Add Oracle JDBC driver #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanstrobl
temporarily deployed
to
docker-publish
GitHub Actions
Inactive
banterCZ
approved these changes
Sep 23, 2024
There was a problem hiding this comment.
The dependency is ok. I am just thinking about the version, cc @zcgandcomp
Spring Boot parent is using <oracle-database.version>21.9.0.0</oracle-database.version>.
Ok, ojdbc 23 should support even 19C https://www.oracle.com/database/technologies/appdev/jdbc-downloads.html |
|
I believe we should use the newest version available, that will most likely provide the best compatibility. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.