Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #224: Liquibase complains about existing indexes on Oracle #237

Merged
merged 2 commits into from
Sep 21, 2024
Merged

Fix #224: Liquibase complains about existing indexes on Oracle #237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bcb33fb
Fix #224: Liquibase complains about existing indexes on Oracle
romanstrobl Sep 19, 2024
fee2d3e
Remove unnecessary indexes from DDL
romanstrobl Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 1 addition & 13 deletions docs/db/changelog/changesets/user-data-store/0.1.x/20230322-audit-indexes.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,19 +58,7 @@
<rollback />
</changeSet>

<changeSet id="5" logicalFilePath="user-data-store/0.1.x/20230322-audit-indexes.xml" author="Lubos Racansky">
<preConditions onFail="MARK_RAN">
<not>
<indexExists tableName="audit_param" indexName="audit_param_log" />
</not>
</preConditions>
<comment>Create a new index on audit_param(audit_log_id)</comment>
<createIndex tableName="audit_param" indexName="audit_param_log">
<column name="audit_log_id" />
</createIndex>
<!-- no rollback on purpose, the audit tables may be shared across several components -->
<rollback />
</changeSet>
<!-- changeSet id="5" was removed because it clashes with an index generated for the primary key column -->

<changeSet id="6" logicalFilePath="user-data-store/0.1.x/20230322-audit-indexes.xml" author="Lubos Racansky">
<preConditions onFail="MARK_RAN">
Expand Down
5 changes: 0 additions & 5 deletions docs/sql/mssql/create-schema.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,6 @@ GO
CREATE NONCLUSTERED INDEX audit_log_type ON audit_log(audit_type);
GO

-- Changeset user-data-store/0.1.x/20230322-audit-indexes.xml::5::Lubos Racansky
-- Create a new index on audit_param(audit_log_id)
CREATE NONCLUSTERED INDEX audit_param_log ON audit_param(audit_log_id);
GO

-- Changeset user-data-store/0.1.x/20230322-audit-indexes.xml::6::Lubos Racansky
-- Create a new index on audit_param(timestamp_created)
CREATE NONCLUSTERED INDEX audit_param_timestamp ON audit_param(timestamp_created);
Expand Down
4 changes: 0 additions & 4 deletions docs/sql/oracle/create-schema.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,6 @@ CREATE INDEX audit_log_level ON audit_log(audit_level);
-- Create a new index on audit_log(audit_type)
CREATE INDEX audit_log_type ON audit_log(audit_type);

-- Changeset user-data-store/0.1.x/20230322-audit-indexes.xml::5::Lubos Racansky
-- Create a new index on audit_param(audit_log_id)
CREATE INDEX audit_param_log ON audit_param(audit_log_id);

-- Changeset user-data-store/0.1.x/20230322-audit-indexes.xml::6::Lubos Racansky
-- Create a new index on audit_param(timestamp_created)
CREATE INDEX audit_param_timestamp ON audit_param(timestamp_created);
Expand Down
4 changes: 0 additions & 4 deletions docs/sql/postgresql/create-schema.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,6 @@ CREATE INDEX audit_log_level ON audit_log(audit_level);
-- Create a new index on audit_log(audit_type)
CREATE INDEX audit_log_type ON audit_log(audit_type);

-- Changeset user-data-store/0.1.x/20230322-audit-indexes.xml::5::Lubos Racansky
-- Create a new index on audit_param(audit_log_id)
CREATE INDEX audit_param_log ON audit_param(audit_log_id);

-- Changeset user-data-store/0.1.x/20230322-audit-indexes.xml::6::Lubos Racansky
-- Create a new index on audit_param(timestamp_created)
CREATE INDEX audit_param_timestamp ON audit_param(timestamp_created);
Expand Down