-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First version of test server with implementation of code-based activation #44
Conversation
...er/src/main/java/com/wultra/security/powerauth/app/testserver/service/ActivationService.java
Outdated
Show resolved
Hide resolved
...er/src/main/java/com/wultra/security/powerauth/app/testserver/service/ActivationService.java
Outdated
Show resolved
Hide resolved
...er/src/main/java/com/wultra/security/powerauth/app/testserver/service/ActivationService.java
Show resolved
Hide resolved
...server/src/main/java/com/wultra/security/powerauth/app/testserver/util/ResultStatusUtil.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Brilliant work! That's a great start for our new powerauth test server.
I have just few tips for improvements, I've added those as comments.
And I hope that all three left TODOs will be resolved soon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
The pull request contains first version of the test server which can be used for testing of creating activations. Other features will be added later.