PAC with claim #132
Merged
PAC with claim #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…claim function. Rename TOTPParser for PACParser
…r deeplink, also fix and amend tests # Conflicts: # WultraMobileTokenSDK/Operations/Utils/WMTTOTPUtils.swift # WultraMobileTokenSDKTests/TOTPParserTests.swift
kober32
reviewed
Nov 28, 2023
|
2 things: we should add the PACUtils to the documentation (to the section https://github.com/wultra/mtoken-sdk-ios/blob/develop/docs/Using-Operations-Service.md#totp-wmtproximitycheck) |
# Conflicts: # WultraMobileTokenSDKTests/TOTPParserTests.swift
# Conflicts: # WultraMobileTokenSDK.xcodeproj/project.pbxproj # WultraMobileTokenSDK/Operations/Utils/WMTPACUtils.swift # WultraMobileTokenSDKTests/TOTPParserTests.swift
kober32
requested changes
Jan 5, 2024
Hopsaheysa
added a commit
that referenced
this pull request
Jul 31, 2024
* Implement new Operation Endpoint Claim and extend WMTOperations with claim function. Rename TOTPParser for PACParser * #125: update parser so it is able to parse deeplink and also JWT in QR code * Implement Detail endpoint and getDetail method to OperationsImpl * Add docs for PACUtils * Remove WMTPACUtils Keys from docs and add description of topt format in JWT/query * Remove unneccesary spaces from doc * Format docs * Improved PAC Utils # Conflicts: # WultraMobileTokenSDKTests/TOTPParserTests.swift * Remove `Package.resolved` * Fix endpoints to be signed with token * Update docs * Implement detail and claim integration tests * Rename WMTClaim file * Improve claim integration test * Improve docs * Fix claim docs --------- Co-authored-by: Jan Kobersky <[email protected]>
kober32
pushed a commit
that referenced
this pull request
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated and renamed
TOTPUtilsparser toPACUtils#125implemented #124
OperationDetail endpoint
/api/auth/token/app/operation/detailOperationClaim endpoint
/api/auth/token/app/operation/detail/claim