Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for Huawei notifications #136

Merged
merged 4 commits into from
Feb 15, 2024
Merged

Added support for Huawei notifications #136

merged 4 commits into from
Feb 15, 2024

Conversation

Hopsaheysa
Copy link
Member

Fixes: #134

kober32
kober32 requested changes Feb 14, 2024
View reviewed changes
Copy link
Member

@kober32 kober32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is OK, but the documentation needs more love.

docs/Using-Push-Service.md Outdated Show resolved Hide resolved
docs/Using-Push-Service.md Outdated Show resolved Hide resolved
docs/Using-Push-Service.md Outdated Show resolved Hide resolved
docs/Using-Push-Service.md Outdated Show resolved Hide resolved
docs/Using-Push-Service.md Outdated Show resolved Hide resolved
kober32
kober32 approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@kober32 kober32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 nice

@Hopsaheysa Hopsaheysa merged commit ee125bc into develop Feb 15, 2024
4 checks passed
@Hopsaheysa Hopsaheysa deleted the issues/huawei-push branch February 15, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kober32 kober32 kober32 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for Huawei Push Kit
2 participants
@Hopsaheysa @kober32