Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated amount and conversion cells to new backend scheme #129

Merged
merged 3 commits into from
Jan 12, 2024

Conversation

Hopsaheysa
Copy link
Member

No description provided.

Copy link
Member

@kober32 kober32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs some changes + we need tests for it.

  • write a new test where only amount and currency come for both amount and conversion to simulate current backend behavior
  • write a new test where only amountFormated and currencyFormated for both amount and conversion to simulate new backend behavior

…be null for amount & conversion cell and write tests for deserialization
Copy link
Member

@kober32 kober32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Hopsaheysa Hopsaheysa merged commit bdafca8 into develop Jan 12, 2024
4 checks passed
@Hopsaheysa Hopsaheysa deleted the amount-new-backend-scheme branch January 12, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants