Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAC with claim #114

Merged
merged 10 commits into from
Jan 9, 2024
Merged

PAC with claim #114

merged 10 commits into from
Jan 9, 2024

Conversation

Hopsaheysa
Copy link
Member

updated and renamed TOTPUtils parser to PACUtils #108

implemented #111
detailEndpoint /api/auth/token/app/operation/detail
claimEndpoint /api/auth/token/app/operation/detail/claim

@kober32
Copy link
Member

kober32 commented Nov 28, 2023

2 things:

# Conflicts:
#	library/src/main/java/com/wultra/android/mtokensdk/operation/PACUtils.kt
…imDetailData` so it better suits for both requests. Pass the result of request directly without adding it to the operations list
@Hopsaheysa Hopsaheysa marked this pull request as ready for review January 2, 2024 16:34
Copy link
Member

@kober32 kober32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK, but where are the documentation and tests like on iOS? :)

kober32
kober32 previously approved these changes Jan 9, 2024
Copy link
Member

@kober32 kober32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Just fix the docs indentation

docs/Using-Operations-Service.md Outdated Show resolved Hide resolved
@Hopsaheysa Hopsaheysa merged commit 76fe2c3 into develop Jan 9, 2024
4 checks passed
@Hopsaheysa Hopsaheysa deleted the features/111-PAC-with-claim branch January 9, 2024 13:53
Hopsaheysa added a commit that referenced this pull request Jul 31, 2024
* #107 - change `TOTPUtils` to `PACUtils` and update format to handle JWTs but also deeplinks

* #111 - implement claim and detail endpoints

* Fix detail and claim endpoints, rename request class to `OperationClaimDetailData` so it better suits for both requests. Pass the result of request directly without adding it to the operations list

* Add Integration tests for getDetail and claim

* Add docs for claim and getDetail

* Fix ktlint

* Fix docs indentation

* Fix docs claim indentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants