Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support of QR Code & Deeplink - Proximity check #104

Merged
merged 12 commits into from
Nov 20, 2023
Merged

Added support of QR Code & Deeplink - Proximity check #104

merged 12 commits into from
Nov 20, 2023

Conversation

Hopsaheysa
Copy link
Member

Fixes #102

kober32
kober32 requested changes Nov 14, 2023
View reviewed changes
Copy link
Member

@kober32 kober32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks OK, just some minor issues.

docs/Using-Operations-Service.md Outdated Show resolved Hide resolved
docs/Using-Operations-Service.md Outdated Show resolved Hide resolved
docs/Using-Operations-Service.md Outdated Show resolved Hide resolved
...ary/src/main/java/com/wultra/android/mtokensdk/api/operation/model/AuthorizeRequestObject.kt Outdated Show resolved Hide resolved
library/src/main/java/com/wultra/android/mtokensdk/operation/TOTPUtils.kt Show resolved Hide resolved
library/src/main/java/com/wultra/android/mtokensdk/operation/TOTPUtils.kt Outdated Show resolved Hide resolved
library/src/main/java/com/wultra/android/mtokensdk/operation/TOTPUtils.kt Outdated Show resolved Hide resolved
@Hopsaheysa Hopsaheysa requested review from kober32 and removed request for kober32 November 15, 2023 09:58
kober32
kober32 approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@kober32 kober32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Hopsaheysa Hopsaheysa merged commit 3c15f31 into develop Nov 20, 2023
4 checks passed
@Hopsaheysa Hopsaheysa deleted the 102-totp-proximity-check branch November 20, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kober32 kober32 kober32 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for TOPT Proximity Check
2 participants
@Hopsaheysa @kober32