fix for issue 28

[indika-dev]

Purpose

Fix for #28

Goals

WSDL from #28 is parsed correctly

Approach

added a check on 0 for path.length in org.wso2.soaptorest.SOAPRequestBodyGenerator:353

User stories

N/A

Release note

fix #28

Documentation

N/A

Training

N/A

Certification

N/A because I don't know, if this is needed

Marketing

N/A

Automation tests

• Unit tests

  added org.wso2.soaptorest.SOAPToRESTConverterTest.testIssue28() and src/test/resources/issue-28/failing.wsdl from bugreport

• Integration tests

  N/A

Security checks

• Followed secure coding standards in http://wso2.com/technical-reports/wso2-secure-engineering-guidelines? yes
• Ran FindSecurityBugs plugin and verified report? no
• Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets? yes

Samples

N/A

Related PRs

N/A

Migrations (if applicable)

N/A

Test environment

Oracle JDK 17.0.12

Learning

Looked at code and saw, that a check was missing for values out of a distinct interval which should be either handled by a warning message or a default value

[CLAassistant]

All committers have signed the CLA.

[rosensilva]

Hi @indika-dev,

Thank you for your valuable contribution. Could you please address the review comment?
Regards,
Rosen

[indika-dev]

Do you mean the conflict with .gitignore?

Kind regards,
Stefan

[rosensilva]

when we check out the src/main/java/org/wso2/soaptorest/SOAPRequestBodyGenerator.java file, we can see that there are 724 lines of code changes. It's a bit tricky to figure out the actual changes just by looking at the PR. This PR includes both code formatting git diff and real fix diff. Ideally, if we're fixing the formatting, it would be great to do it in a separate commit.

Thanks!

[indika-dev]

I'm very sorry for the inconvinience. I recommitted the changed files without reformatting the whole file. Please have a look at it.