Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TS issues due to invalid @oxygen-ui properties #7063

Merged
merged 5 commits into from
Oct 29, 2024

Conversation

brionmario
Copy link
Member

@brionmario brionmario commented Oct 29, 2024

Purpose

Versions of oxygen-ui/react is inconsistent between features.

Related Issues

Related PRs

  • N/A

Checklist

  • e2e cypress tests locally verified. (for internal contributers)
  • Manual test round performed and verified.
  • UX/UI review done on the final implementation.
  • Documentation provided. (Add links if there are any)
  • Relevant backend changes deployed and verified
  • Unit tests provided. (Add links if there are any)
  • Integration tests provided. (Add links if there are any)

Security checks

@brionmario brionmario changed the title Fix inconsistent oxygen versions Fix TS issues due to invalid @oxygen-ui properties Oct 29, 2024
@wso2-jenkins-bot
Copy link
Contributor

🦋 Changeset detected

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.79%. Comparing base (03cb8bf) to head (13fc4b3).
Report is 138 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7063   +/-   ##
=======================================
  Coverage   31.79%   31.79%           
=======================================
  Files          41       41           
  Lines         890      890           
  Branches      206      204    -2     
=======================================
  Hits          283      283           
- Misses        587      607   +20     
+ Partials       20        0   -20     
Flag Coverage Δ
@wso2is/core 31.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 6 files with indirect coverage changes

@brionmario brionmario merged commit 0034e20 into wso2:master Oct 29, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants