Reuse shared components in API Policies #536
Conversation
...isher/src/main/webapp/source/src/app/components/Apis/Details/Policies/AttachedPolicyList.tsx
Outdated
Show resolved
Hide resolved
| handlePolicyDownload={handlePolicyDownload} | ||
| handleDelete={handleDelete} | ||
| setDrawerOpen={setDrawerOpen} | ||
| PolicyConfigurationEditDrawer={PolicyConfigurationEditDrawer} |
There was a problem hiding this comment.
Why are we passing down a component here? Can't we simply import the required component within the shared component itself (i.e. within AttachedPolicyCardShared)
There was a problem hiding this comment.
We cannot do that as the shared component is shared by two different features. Since those have different data contexts and different funtionalities, we cannot import them as a common identical one in the shared component. By passing them down to components, we do not need seperate implementations to identify the compoenent's feature.
...isher/src/main/webapp/source/src/app/components/Apis/Details/Policies/AttachedPolicyList.tsx
Show resolved
Hide resolved
...lisher/src/main/webapp/source/src/app/components/Apis/Details/Policies/PoliciesExpansion.tsx
Show resolved
Hide resolved
...publisher/src/main/webapp/source/src/app/components/Apis/Details/Policies/PolicyDropzone.tsx
Show resolved
Hide resolved
| currentFlow={currentFlow} | ||
| policyList={policyList} | ||
| fetchPolicies={fetchPolicies} | ||
| DraggablePolicyCard={DraggablePolicyCard} |
There was a problem hiding this comment.
Here too. Also, shall we move out the components such as FlowArrow.tsx files to the shared folder?
There was a problem hiding this comment.
I have used a FlowArrow.tsx shared file in the shared folder and reused them in both features. Eventhough it has only direction as a data (Which is not a problem for resuing in both features) I kept the file structure as it is for the readability. Becase if so, the only file missing will be that and I thought it will confuse people. If we need, we can completely remove it from both features as it's in the bottom of the react components of both features.
$Subject