Provide support for In-memory template manager #254
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR builder started |
|
PR builder completed |
jenkins-is-staging
approved these changes
Aug 20, 2024
There was a problem hiding this comment.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/10469159397
Thumimku
force-pushed
the
inMemoryTemplateImpl
branch
from
4ce3650
to
be1327c
Compare
Thumimku
force-pushed
the
inMemoryTemplateImpl
branch
from
be1327c
to
d2bb554
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes in this pull request
Currently email/sms templates are stored in the registry, for any sub tenants we are not adding new templates when server startup. When creating any tenants we are adding default email templates to the registry per tenant, this leaves redundant data. With this fix, we are providing In-memory template manager which return dafault templates and act on read only mode.
Currently, it works with hybrid template manager and db-based template manager also.
TODO: