Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C++ Alerts do not handle move/delete properly #7224

Open
rzblue opened this issue Oct 17, 2024 · 1 comment
Open

C++ Alerts do not handle move/delete properly #7224

rzblue opened this issue Oct 17, 2024 · 1 comment
Assignees
@rzblue
Labels
type: bug Something isn't working.

Comments

@rzblue
Copy link
Member

rzblue commented Oct 17, 2024 •
edited
Loading

Alert adds std::shared_ptr(this) to the SendableAlerts in its constructor, which is invalidated if the alert is moved or deleted.
@rzblue rzblue added the type: bug Something isn't working. label Oct 17, 2024
@rzblue
Copy link
Member Author

rzblue commented Oct 17, 2024 •
edited
Loading

I'm working on fixing this. There will be a behavior change in that creating 2 alerts with the same name will result in an exception being thrown, which I believe is the correct behavior (this behavior will also be ported to java).

@rzblue rzblue self-assigned this Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rzblue rzblue

Labels
type: bug Something isn't working.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rzblue