Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(texture): dispose of textures when no longer in use #16

Merged
merged 2 commits into from
Dec 29, 2023

Conversation

fallenoak
Copy link
Member

This PR permits garbage collection and WebGL clean up for textures produced by TextureManager.

@codecov-commenter
Copy link

codecov-commenter commented Dec 29, 2023

Codecov Report

Attention: 43 lines in your changes are missing coverage. Please review.

Comparison is base (ca01329) 21.42% compared to head (29e0508) 20.71%.

Files Patch % Lines
src/lib/texture/TextureManager.ts 0.00% 25 Missing and 4 partials ⚠️
src/lib/texture/ManagedCompressedTexture.ts 0.00% 6 Missing and 1 partial ⚠️
src/lib/texture/ManagedDataTexture.ts 0.00% 6 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #16      +/-   ##
==========================================
- Coverage   21.42%   20.71%   -0.71%     
==========================================
  Files          20       22       +2     
  Lines         915      946      +31     
  Branches      189      195       +6     
==========================================
  Hits          196      196              
- Misses        623      648      +25     
- Partials       96      102       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fallenoak fallenoak merged commit f316e96 into main Dec 29, 2023
2 checks passed
@fallenoak fallenoak deleted the feat-texture-add-support-for-texture-disposal branch December 29, 2023 18:29
@github-actions github-actions bot mentioned this pull request Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants