chore(map): reduce allocations of tiny typed arrays

wowserhq · Feb 9, 2024 · d80ef81 · d80ef81
1 parent 3757ca7
commit d80ef81
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 9 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -36,7 +36,7 @@
   ],
   "dependencies": {
     "@tweenjs/tween.js": "^23.1.1",
-    "@wowserhq/format": "^0.23.0"
+    "@wowserhq/format": "^0.24.0"
   },
   "peerDependencies": {
     "three": "^0.160.0"

diff --git a/src/lib/map/loader/types.ts b/src/lib/map/loader/types.ts
@@ -5,8 +5,8 @@ type MapSpec = {
 type MapDoodadDefSpec = {
   id: number;
   name: string;
-  position: Float32Array;
-  rotation: Float32Array;
+  position: number[];
+  rotation: number[];
   scale: number;
 };
 
@@ -34,7 +34,7 @@ type TerrainGeometrySpec = {
 };
 
 type TerrainSpec = {
-  position: Float32Array;
+  position: number[];
   geometry: TerrainGeometrySpec;
   material: TerrainMaterialSpec;
 };

diff --git a/src/lib/map/terrain/TerrainMesh.ts b/src/lib/map/terrain/TerrainMesh.ts
@@ -1,7 +1,7 @@
 import * as THREE from 'three';
 
 class TerrainMesh extends THREE.Mesh {
-  constructor(position: Float32Array, geometry: THREE.BufferGeometry, material: THREE.Material) {
+  constructor(position: number[], geometry: THREE.BufferGeometry, material: THREE.Material) {
     super(geometry, material);
 
     this.position.set(position[0], position[1], position[2]);